CVS update: samba/source/lib

tridge at samba.org tridge at samba.org
Mon Feb 2 12:02:44 GMT 2004


Date:	Mon Feb  2 12:02:44 2004
Author:	tridge

Update of /home/cvs/samba/source/lib
In directory dp.samba.org:/tmp/cvs-serv30958

Modified Files:
      Tag: SAMBA_3_0
	charcnv.c 
Log Message:
the conversion from int to size_t in charcnv did not take into account
one place where we checked "if (src_len > 0)".

I actually would greatly prefer to switch back to int for src_len. The
type *can* be negative, which means an unsigned type is
inappropriate. There is absolutely no reason why "int" should not be
used for a parameter like this. 

I didn't change back to int as we are close to a release and I wanted
a mininal change, but please don't go changing types like this in
future without very careful testing and a damn good reason.

this bug broke pull_ucs2(), I would not be surprised if it caused all
sorts of nastiness. Thanks to vl for noticing the symptoms!


Revisions:
charcnv.c		1.55.2.48 => 1.55.2.49
	http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/charcnv.c.diff?r1=1.55.2.48&r2=1.55.2.49


More information about the samba-cvs mailing list