svn commit: samba r4261 - in branches/SAMBA_4_0/source: include libcli/raw ntvfs/posix smb_server torture

Stefan (metze) Metzmacher metze at samba.org
Sat Dec 18 16:56:33 GMT 2004


tridge at samba.org schrieb:
> Author: tridge
> Date: 2004-12-17 22:47:49 +0000 (Fri, 17 Dec 2004)
> New Revision: 4261
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4261
> 
> Log:
> added the RAW_FILEINFO_EA_LIST trans2 qfileinfo and qpathinfo
> level. Interestingly, this level did now show up on our trans2 scanner
> previously as we didn't have the FLAGS2_EXTENDED_ATTRIBUTES bit set in
> the client code. Now that we set that bit, new levels appear in
> windows servers.
> 
> Modified:
>    branches/SAMBA_4_0/source/include/smb_interfaces.h
>    branches/SAMBA_4_0/source/include/trans2.h
>    branches/SAMBA_4_0/source/libcli/raw/raweas.c
>    branches/SAMBA_4_0/source/libcli/raw/rawfileinfo.c
>    branches/SAMBA_4_0/source/ntvfs/posix/pvfs_qfileinfo.c
>    branches/SAMBA_4_0/source/smb_server/trans2.c
>    branches/SAMBA_4_0/source/torture/torture_util.c
> 
-	/* trans2 RAW_FILEINFO_ALL_EAS interface */
+	/* trans2 RAW_FILEINFO_EA_LIST interface */
  	struct {
  		enum smb_fileinfo_level level;
-		union smb_fileinfo_in in;
+		union smb_fileinfo_in file;

+		struct {
+			uint_t num_names;
+			struct ea_name {
+				WIRE_STRING name;
+			} *ea_names;	
+		} in;	
+

Hi tridge,

reading through the patch union smb_fileinfo_in file is not used, is that correct?
how does it apears on the wire?

if it's needed I would move it into the "in" struct to make it more clear that this in an input
parameter and also make it consitent with the other unions where we always only have .level, .in and
.out.

-- 
metze

Stefan Metzmacher <metze at samba.org> www.samba.org


More information about the samba-cvs mailing list