svn commit: samba r4236 - in branches/SAMBA_3_0/source: auth lib
smbwrapper torture
jra at samba.org
jra at samba.org
Thu Dec 16 21:12:29 GMT 2004
Author: jra
Date: 2004-12-16 21:12:29 +0000 (Thu, 16 Dec 2004)
New Revision: 4236
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4236
Log:
More *alloc fixes.
Jeremy.
Modified:
branches/SAMBA_3_0/source/auth/pampass.c
branches/SAMBA_3_0/source/lib/sysquotas.c
branches/SAMBA_3_0/source/smbwrapper/smbw.c
branches/SAMBA_3_0/source/smbwrapper/smbw_cache.c
branches/SAMBA_3_0/source/torture/cmd_vfs.c
Changeset:
Modified: branches/SAMBA_3_0/source/auth/pampass.c
===================================================================
--- branches/SAMBA_3_0/source/auth/pampass.c 2004-12-16 21:06:40 UTC (rev 4235)
+++ branches/SAMBA_3_0/source/auth/pampass.c 2004-12-16 21:12:29 UTC (rev 4236)
@@ -59,7 +59,7 @@
/*
* Macros to help make life easy
*/
-#define COPY_STRING(s) (s) ? strdup(s) : NULL
+#define COPY_STRING(s) (s) ? SMB_STRDUP(s) : NULL
/*******************************************************************
PAM error handler.
Modified: branches/SAMBA_3_0/source/lib/sysquotas.c
===================================================================
--- branches/SAMBA_3_0/source/lib/sysquotas.c 2004-12-16 21:06:40 UTC (rev 4235)
+++ branches/SAMBA_3_0/source/lib/sysquotas.c 2004-12-16 21:12:29 UTC (rev 4236)
@@ -73,9 +73,9 @@
continue ;
if (S.st_dev == devno) {
- (*mntpath) = strdup(mnt->mnt_dir);
- (*bdev) = strdup(mnt->mnt_fsname);
- (*fs) = strdup(mnt->mnt_type);
+ (*mntpath) = SMB_STRDUP(mnt->mnt_dir);
+ (*bdev) = SMB_STRDUP(mnt->mnt_fsname);
+ (*fs) = SMB_STRDUP(mnt->mnt_type);
if ((*mntpath)&&(*bdev)&&(*fs)) {
ret = 0;
} else {
@@ -124,8 +124,8 @@
* but I don't know how
* --metze
*/
- (*mntpath) = strdup(path);
- (*bdev) = strdup(dev_disk);
+ (*mntpath) = SMB_STRDUP(path);
+ (*bdev) = SMB_STRDUP(dev_disk);
if ((*mntpath)&&(*bdev)) {
ret = 0;
} else {
@@ -152,7 +152,7 @@
(*bdev) = NULL;
(*fs) = NULL;
- (*mntpath) = strdup(path);
+ (*mntpath) = SMB_STRDUP(path);
if (*mntpath) {
ret = 0;
} else {
Modified: branches/SAMBA_3_0/source/smbwrapper/smbw.c
===================================================================
--- branches/SAMBA_3_0/source/smbwrapper/smbw.c 2004-12-16 21:06:40 UTC (rev 4235)
+++ branches/SAMBA_3_0/source/smbwrapper/smbw.c 2004-12-16 21:12:29 UTC (rev 4236)
@@ -546,7 +546,7 @@
DEBUG(4,(" tconx ok\n"));
- srv = (struct smbw_server *)malloc(sizeof(*srv));
+ srv = SMB_MALLOC_P(struct smbw_server);
if (!srv) {
errno = ENOMEM;
goto failed;
@@ -558,25 +558,25 @@
srv->dev = (dev_t)(str_checksum(server) ^ str_checksum(share));
- srv->server_name = strdup(server);
+ srv->server_name = SMB_STRDUP(server);
if (!srv->server_name) {
errno = ENOMEM;
goto failed;
}
- srv->share_name = strdup(share);
+ srv->share_name = SMB_STRDUP(share);
if (!srv->share_name) {
errno = ENOMEM;
goto failed;
}
- srv->workgroup = strdup(workgroup);
+ srv->workgroup = SMB_STRDUP(workgroup);
if (!srv->workgroup) {
errno = ENOMEM;
goto failed;
}
- srv->username = strdup(username);
+ srv->username = SMB_STRDUP(username);
if (!srv->username) {
errno = ENOMEM;
goto failed;
@@ -664,7 +664,7 @@
return fd;
}
- file = (struct smbw_file *)malloc(sizeof(*file));
+ file = SMB_MALLOC_P(struct smbw_file);
if (!file) {
errno = ENOMEM;
goto failed;
@@ -672,7 +672,7 @@
ZERO_STRUCTP(file);
- file->f = (struct smbw_filedes *)malloc(sizeof(*(file->f)));
+ file->f = SMB_MALLOC_P(struct smbw_filedes);
if (!file->f) {
errno = ENOMEM;
goto failed;
@@ -681,7 +681,7 @@
ZERO_STRUCTP(file->f);
file->f->cli_fd = fd;
- file->f->fname = strdup(path);
+ file->f->fname = SMB_STRDUP(path);
if (!file->f->fname) {
errno = ENOMEM;
goto failed;
@@ -1288,7 +1288,7 @@
goto failed;
}
- file2 = (struct smbw_file *)malloc(sizeof(*file2));
+ file2 = SMB_MALLOC_P(struct smbw_file);
if (!file2) {
close(fd2);
errno = ENOMEM;
@@ -1340,7 +1340,7 @@
goto failed;
}
- file2 = (struct smbw_file *)malloc(sizeof(*file2));
+ file2 = SMB_MALLOC_P(struct smbw_file);
if (!file2) {
close(fd2);
errno = ENOMEM;
Modified: branches/SAMBA_3_0/source/smbwrapper/smbw_cache.c
===================================================================
--- branches/SAMBA_3_0/source/smbwrapper/smbw_cache.c 2004-12-16 21:06:40 UTC (rev 4235)
+++ branches/SAMBA_3_0/source/smbwrapper/smbw_cache.c 2004-12-16 21:12:29 UTC (rev 4236)
@@ -65,14 +65,14 @@
struct name_list **name_list = (struct name_list **)state;
struct name_list *new_name;
- new_name = (struct name_list *)malloc(sizeof(struct name_list));
+ new_name = SMB_MALLOC_P(struct name_list);
if (!new_name) return;
ZERO_STRUCTP(new_name);
- new_name->name = strdup(name);
+ new_name->name = SMB_STRDUP(name);
new_name->stype = stype;
- new_name->comment = strdup(comment);
+ new_name->comment = SMB_STRDUP(comment);
DLIST_ADD(*name_list, new_name);
}
@@ -117,8 +117,7 @@
/* No names cached for this workgroup */
if (names == NULL) {
- new_names = (struct cached_names *)
- malloc(sizeof(struct cached_names));
+ new_names = SMB_MALLOC_P(struct cached_names);
ZERO_STRUCTP(new_names);
DLIST_ADD(cached_names, new_names);
@@ -139,7 +138,7 @@
new_names->cache_timeout = now;
new_names->result = result;
- new_names->key = strdup(key);
+ new_names->key = SMB_STRDUP(key);
names = new_names;
}
@@ -173,8 +172,7 @@
/* No names cached for this server */
if (names == NULL) {
- new_names = (struct cached_names *)
- malloc(sizeof(struct cached_names));
+ new_names = SMB_MALLOC_P(struct cached_names);
ZERO_STRUCTP(new_names);
DLIST_ADD(cached_names, new_names);
@@ -193,7 +191,7 @@
&new_names->name_list);
new_names->cache_timeout = now;
- new_names->key = strdup(key);
+ new_names->key = SMB_STRDUP(key);
names = new_names;
}
Modified: branches/SAMBA_3_0/source/torture/cmd_vfs.c
===================================================================
--- branches/SAMBA_3_0/source/torture/cmd_vfs.c 2004-12-16 21:06:40 UTC (rev 4235)
+++ branches/SAMBA_3_0/source/torture/cmd_vfs.c 2004-12-16 21:12:29 UTC (rev 4236)
@@ -285,7 +285,7 @@
}
vfs->files[fd] = (struct files_struct *)malloc(sizeof(struct files_struct));
- vfs->files[fd]->fsp_name = strdup(argv[1]);
+ vfs->files[fd]->fsp_name = SMB_STRDUP(argv[1]);
vfs->files[fd]->fd = fd;
vfs->files[fd]->conn = vfs->conn;
printf("open: fd=%d\n", fd);
More information about the samba-cvs
mailing list