svn commit: samba r4206 - in branches/SAMBA_4_0/source/rpc_server/lsa: .

tridge at samba.org tridge at samba.org
Tue Dec 14 22:18:34 GMT 2004


Author: tridge
Date: 2004-12-14 22:18:33 +0000 (Tue, 14 Dec 2004)
New Revision: 4206

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4206

Log:
fixed a status code check in lsa_LookupNames2 that could cause a segv



Modified:
   branches/SAMBA_4_0/source/rpc_server/lsa/dcesrv_lsa.c


Changeset:
Modified: branches/SAMBA_4_0/source/rpc_server/lsa/dcesrv_lsa.c
===================================================================
--- branches/SAMBA_4_0/source/rpc_server/lsa/dcesrv_lsa.c	2004-12-14 22:17:41 UTC (rev 4205)
+++ branches/SAMBA_4_0/source/rpc_server/lsa/dcesrv_lsa.c	2004-12-14 22:18:33 UTC (rev 4206)
@@ -691,8 +691,9 @@
 /* 
   lsa_EnumPrivsAccount 
 */
-static NTSTATUS lsa_EnumPrivsAccount(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-		       struct lsa_EnumPrivsAccount *r)
+static NTSTATUS lsa_EnumPrivsAccount(struct dcesrv_call_state *dce_call, 
+				     TALLOC_CTX *mem_ctx,
+				     struct lsa_EnumPrivsAccount *r)
 {
 	DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
 }
@@ -1375,7 +1376,7 @@
 		r->out.sids->sids[i].unknown     = 0;
 
 		status2 = lsa_lookup_name(state, mem_ctx, name, &sid, &atype);
-		if (!NT_STATUS_IS_OK(status) || sid->num_auths == 0) {
+		if (!NT_STATUS_IS_OK(status2) || sid->num_auths == 0) {
 			status = STATUS_SOME_UNMAPPED;
 			continue;
 		}



More information about the samba-cvs mailing list