svn commit: samba r4120 - in branches/SAMBA_3_0/source/lib: .

jra at samba.org jra at samba.org
Thu Dec 9 21:42:01 GMT 2004


Author: jra
Date: 2004-12-09 21:42:00 +0000 (Thu, 09 Dec 2004)
New Revision: 4120

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4120

Log:
Never, ever, doubt valgrind :-). Fix order of evaluation bug that's been in the
bitmap code for ever. Remove silly extra space in paranoid malloc.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/lib/bitmap.c
   branches/SAMBA_3_0/source/lib/util.c


Changeset:
Modified: branches/SAMBA_3_0/source/lib/bitmap.c
===================================================================
--- branches/SAMBA_3_0/source/lib/bitmap.c	2004-12-09 21:41:58 UTC (rev 4119)
+++ branches/SAMBA_3_0/source/lib/bitmap.c	2004-12-09 21:42:00 UTC (rev 4120)
@@ -41,7 +41,7 @@
 		return NULL;
 	}
 
-	memset(bm->b, 0, sizeof(bm->b[0])*(n+31)/32);
+	memset(bm->b, 0, sizeof(uint32)*((n+31)/32));
 
 	return bm;
 }
@@ -78,7 +78,7 @@
 		return NULL;
 	}
 
-	memset(bm->b, 0, sizeof(bm->b[0])*(n+31)/32);
+	memset(bm->b, 0, sizeof(uint32)*((n+31)/32));
 
 	return bm;
 }
@@ -92,7 +92,7 @@
         int count = MIN(dst->n, src->n);
 
         SMB_ASSERT(dst->b != src->b);
-	memcpy(dst->b, src->b, sizeof(dst->b[0])*(count+31)/32);
+	memcpy(dst->b, src->b, sizeof(uint32)*((count+31)/32));
 
         return count;
 }

Modified: branches/SAMBA_3_0/source/lib/util.c
===================================================================
--- branches/SAMBA_3_0/source/lib/util.c	2004-12-09 21:41:58 UTC (rev 4119)
+++ branches/SAMBA_3_0/source/lib/util.c	2004-12-09 21:42:00 UTC (rev 4120)
@@ -867,9 +867,7 @@
 void *malloc_(size_t size)
 {
 #undef malloc
-	/* If we don't add an amount here the glibc memset seems to write
-	   one byte over. */
-	return malloc(size+16);
+	return malloc(size);
 #define malloc(s) __ERROR_DONT_USE_MALLOC_DIRECTLY
 }
 
@@ -880,9 +878,7 @@
 static void *calloc_(size_t count, size_t size)
 {
 #undef calloc
-	/* If we don't add an amount here the glibc memset seems to write
-	   one byte over. */
-	return calloc(count+1, size);
+	return calloc(count, size);
 #define calloc(n,s) __ERROR_DONT_USE_CALLOC_DIRECTLY
 }
 
@@ -893,9 +889,7 @@
 static void *realloc_(void *ptr, size_t size)
 {
 #undef realloc
-	/* If we don't add an amount here the glibc memset seems to write
-	   one byte over. */
-	return realloc(ptr, size+16);
+	return realloc(ptr, size);
 #define realloc(p,s) __ERROR_DONT_USE_RELLOC_DIRECTLY
 }
 



More information about the samba-cvs mailing list