svn commit: samba r4115 - in branches/SAMBA_4_0/source/librpc/rpc: .

tridge at samba.org tridge at samba.org
Thu Dec 9 10:33:21 GMT 2004


Author: tridge
Date: 2004-12-09 10:33:21 +0000 (Thu, 09 Dec 2004)
New Revision: 4115

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4115

Log:
check for gensec errors before calling memcpy on a set of credentials,
otherwise the creds structure might be invalid


Modified:
   branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c	2004-12-09 10:32:43 UTC (rev 4114)
+++ branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c	2004-12-09 10:33:21 UTC (rev 4115)
@@ -400,6 +400,9 @@
 					    blob->length - 
 					    p->security_state.auth_info->credentials.length,
 					    &creds2);
+		if (!NT_STATUS_IS_OK(status)) {
+			return status;
+		}
 		memcpy(blob->data + blob->length - creds2.length, creds2.data, creds2.length);
 		break;
 
@@ -412,6 +415,9 @@
 					    blob->length - 
 					    p->security_state.auth_info->credentials.length,
 					    &creds2);
+		if (!NT_STATUS_IS_OK(status)) {
+			return status;
+		}
 		memcpy(blob->data + blob->length - creds2.length, creds2.data, creds2.length);
 		break;
 



More information about the samba-cvs mailing list