CVS update: samba/source/smbd

Andrew Bartlett abartlet at samba.org
Sat May 31 13:02:13 EST 2003


On Sat, 2003-05-31 at 11:48, jra at samba.org wrote:
> 
> Date:	Sat May 31 01:48:59 2003
> Author:	jra
> 
> Update of /data/cvs/samba/source/smbd
> In directory dp.samba.org:/tmp/cvs-serv26772/smbd
> 
> Modified Files:
>       Tag: SAMBA_3_0
> 	connection.c negprot.c 
> Log Message:
> Fixes to stop valgrind complaining about uninitialised memory when it's
> copying clobbered buffer areas and doing hashes on them and sending
> them onto the wire.
> Jeremy.
> 
> 
> Revisions:
> connection.c		1.46.2.5 => 1.46.2.6
> 	http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/connection.c?r1=1.46.2.5&r2=1.46.2.6
> negprot.c		1.62.2.8 => 1.62.2.9
> 	http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/negprot.c?r1=1.62.2.8&r2=1.62.2.9

I think this is the wrong fix - for the connection.c stuff (which we
don't send to the wire) we should tdb_pack() the key, not use a C
struct.  

For the negprot case we should return our GUID, not the netbios name.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-cvs/attachments/20030531/a57008ad/attachment.bin


More information about the samba-cvs mailing list