CVS update: samba/source/param

Jim McDonough jmcd at us.ibm.com
Thu May 29 21:58:24 EST 2003





>Jim, this seem a semantic change, can you explain why you think
>allo_sub_basic should be used here??
>What was the problem that made you change lp_string() ?
Yep, bug #117 was winbindd looping such that it could only be killed with
-9.  How is this a semantic change other than substitutions done in parms
can now be longer than 100 chars total?

The problem was that substituions using lp_string were limited to 100 chars
total.  winbindd was trying to substitute a very large username (but it
wouldn't matter really, if it was just a long skeleton pathname).
standard_sub_basic is still broken, because it loops if any of the
sub_string() calls fail to increment the current location pointer.  There
is no provision for failure, and you get a very tight loop.

Do you see a problem with the substitutions?

Jeremy, this is why I was tentative about changing it...

----------------------------
Jim McDonough
IBM Linux Technology Center
Samba Team
6 Minuteman Drive
Scarborough, ME 04074
USA

jmcd at us.ibm.com
jmcd at samba.org

Phone: (207) 885-5565
IBM tie-line: 776-9984




More information about the samba-cvs mailing list