CVS update: samba/source/printing

[Tim Potter]

On Fri, Mar 21, 2003 at 12:58:16AM +0000, jra at samba.org wrote:

> Date:	Fri Mar 21 00:58:16 2003
> Author:	jra
> 
> Update of /data/cvs/samba/source/printing
> In directory dp.samba.org:/tmp/cvs-serv26159/printing
> 
> Modified Files:
>       Tag: APPLIANCE_HEAD
> 	printing.c 
> Log Message:
> Removed 2 full tdb traversals when getting enumjobs. This is complex new
> code to fix CR#2064 and needs reviewing please (JohnR already looked at
> it). It needs merging with 3.0 and HEAD.
> Jeremy.

That looks OK but I am little worried with this code getting more
complex than it already is, as well as race conditions from multiple
smbds trying to updated the queue at once.  It all looks safe behind the
LOCK/printername though.

I think you said it best one time - "this code is horrible and deserves
to die".


Tim.