CVS update: samba/source/libsmb

Rafal Szczesniak mimir at samba.org
Tue Mar 18 21:03:06 EST 2003


On Tue, Mar 18, 2003 at 09:42:50AM +1100, Andrew Bartlett wrote:
> On Tue, 2003-03-18 at 09:24, mimir at samba.org wrote:
> > On Mon, Mar 17, 2003 at 04:42:57AM +0000, abartlet at samba.org wrote:
> > > 
> > > Date:	Mon Mar 17 04:42:57 2003
> > > Author:	abartlet
> > > 
> > > Update of /data/cvs/samba/source/libsmb
> > > In directory dp.samba.org:/tmp/cvs-serv3421/libsmb
> > > 
> > > Modified Files:
> > > 	trusts_util.c 
> > > Log Message:
> > > Fix a memory leak - 'smbcontrol smbd pool-usage' is your freind!
> > 
> > Excuse me, but looking at source code I don't quite understand why
> > to remove this talloc destroy ? If function doesn't return after
> > successful string compare, then initialised talloc should be destroyed
> > before "default" return.
> 
> Correct.  I *added* it :-)

Oh, indeed! I thought I've seen '-' on the left hand side! Well, I was
really tired yesterday night and that's my only excuse :)
Thank you.



cheers,
-- 
 Rafal Szczesniak      mimir[at]diament.ists.pwr.wroc.pl
 Samba Team member     mimir[at]samba.org
+---------------------------------------------------------+
 *BSD, GNU/Linux and Samba          http://www.samba.org
+---------------------------------------------------------+



More information about the samba-cvs mailing list