CVS update: samba/source/lib

abartlet at samba.org abartlet at samba.org
Tue Mar 18 10:06:12 EST 2003


Date:	Mon Mar 17 23:06:12 2003
Author:	abartlet

Update of /home/cvs/samba/source/lib
In directory dp.samba.org:/tmp/cvs-serv16177/lib

Modified Files:
      Tag: SAMBA_3_0
	server_mutex.c 
Log Message:
Merge from HEAD - make winbindd locking sane again:

Original message:


This patch attemptes to clean up winbindd's mutex locking.

The current locking scheme in winbind is a complete mess - indeed, the
next step should be to push the locking into cli_full_connection(), but
I'll leave it for now.

This patch works on the noted behaviour that 2 parts of the connection
process need protection - and independent protection.  Tim Potter did
some work on this a little while back, verifying the second case.

The two cases are: 
 - between connect() and first session setup
 - during the auth2 phase of the netlogon pipe setup.

I've removed the counter on the lock, as I fail to see what it gains us.

This patch also adds 'anonymous fallback' to our winbindd -> DC connection.  

If the authenticated connection fails (wbinfo -A specifed) - say that 
account isn't trusted by a trusted DC - then we try an anonymous.

Both tpot and mbp like the patch.

Andrew Bartlett


Revisions:
server_mutex.c		1.1.2.3 => 1.1.2.4
	http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/server_mutex.c?r1=1.1.2.3&r2=1.1.2.4


More information about the samba-cvs mailing list