CVS update: samba/source/nsswitch

[Andrew Bartlett]

On Sat, 2003-06-21 at 14:05, jerry at samba.org wrote:
> 
> Date:	Sat Jun 21 04:05:00 2003
> Author:	jerry
> 
> Update of /data/cvs/samba/source/nsswitch
> In directory dp.samba.org:/tmp/cvs-serv31338/nsswitch
> 
> Modified Files:
>       Tag: SAMBA_3_0
> 	wb_client.c winbindd.c winbindd.h winbindd_cache.c 
> 	winbindd_cm.c winbindd_group.c winbindd_pam.c winbindd_rpc.c 
> Log Message:
> merge of the netsamlogon caching code from APPLIANCE_HEAD
> This replaces the universal group caching code (was originally
> based on that code).  Only applies to the the RPC code.
> 
> One comment: domain local groups don't show up in 'getent group'
> that's easy to fix.
> 
> Code has been tested against 2k domain but doesn't change anything
> with respect to NT4 domains.
> 
> netsamlogon caching works pretty much like the universal group
> caching code did but has had much more testing and puts winbind
> mostly back in sync between branches.

Just a few comments: 
 - I'm worried about removing the 'server disabled' checks - what stops
us beating on dead servers?

 - You didn't remove the old netlogon_unigroup code

 - Why is the cache in the form 'domain-name/rid'?  What's wrong with
the full SID, as the netlogon unigroup code did?

 - We need to use the parsed information in the PAC or else we are going
to get *very* inconsistent results with clients who 'sometimes' use
Kerberos.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-cvs/attachments/20030621/7c8e78dd/attachment.bin