CVS update: samba/source
tridge at samba.org
tridge at samba.org
Mon Jun 16 12:22:38 EST 2003
Date: Mon Jun 16 02:22:38 2003
Author: tridge
Update of /home/cvs/samba/source
In directory dp.samba.org:/tmp/cvs-serv31729
Modified Files:
Tag: SAMBA_3_0
configure.in
Log Message:
reverted locale patch put in by jht (originally from vorlon).
There are lots of things wrong with this patch, including:
1) it overrides a user chosen configuration option
2) it adds lots of complexity inside a loop when a tiny piece of code
outside the loop would do the same thing
3) it does no error checking, and is sure to crash on some systems
If you want this functionality then try something like this at the end
of charset_name():
#ifdef HAVE_NL_LANGINFO
if (strcasecmp(ret, "LOCALE") == 0) {
const char *ln = nl_langinfo(CODESET);
if (ln) {
DEBUG(5,("Substituting charset '%s' for LOCALE\n", ln));
return ln;
}
}
#endif
then users can set 'display charset = LOCALE' to get the locale based
charset. You could even make that the default for systems that have
nl_langinfo().
Revisions:
configure.in 1.300.2.100 => 1.300.2.101
http://www.samba.org/cgi-bin/cvsweb/samba/source/configure.in.diff?r1=1.300.2.100&r2=1.300.2.101
More information about the samba-cvs
mailing list