CVS update: samba/source/include

abartlet at samba.org abartlet at samba.org
Mon Jul 14 18:46:31 EST 2003


Date:	Mon Jul 14 08:46:31 2003
Author:	abartlet

Update of /home/cvs/samba/source/include
In directory dp.samba.org:/tmp/cvs-serv9358/include

Modified Files:
      Tag: SAMBA_3_0
	client.h ntlmssp.h rpc_dce.h 
Log Message:
Jeremy requested that I get my NTLMSSP patch into CVS.  He didn't request
the schannel code, but I've included that anyway. :-)

This patch revives the client-side NTLMSSP support for RPC named pipes
in Samba, and cleans up the client and server schannel code.  The use of the 
new code is enabled by the 'sign', 'seal' and 'schannel' commands in 
rpcclient.

The aim was to prove that our separate NTLMSSP client library actually 
implements NTLMSSP signing and sealing as per Microsoft's NTLMv1 implementation,
in the hope that knowing this will assist us in correctly implementing 
NTLMSSP signing for SMB packets.  (Still not yet functional)

This patch replaces the NTLMSSP implementation in rpc_client/cli_pipe.c with
calls to libsmb/ntlmssp.c.  In the process, we have gained the ability to
use the more secure NT password, and the ability to sign-only, instead of 
having to seal the pipe connection.  (Previously we were limited to sealing, 
and could only use the LM-password derived key).

Our new client-side NTLMSSP code also needed alteration to cope with our 
comparatively simple server-side implementation.  A future step is to replace
it with calls to the same NTLMSSP library.

Also included in this patch is the schannel 'sign only' patch I submitted to
the team earlier.  While not enabled (and not functional, at this stage) the 
work in this patch makes the code paths *much* easier to follow.  I have also 
included similar hooks in rpccleint to allow the use of schannel on *any* pipe.  

rpcclient now defaults to not using schannel (or any other extra per-pipe 
authenticiation) for any connection.  The 'schannel' command enables schannel
for all pipes until disabled.

This code is also much more secure than the previous code, as changes to our
cli_pipe routines ensure that the authentication footer cannot be removed
by an attacker, and more error states are correctly handled.

(The same needs to be done to our server)

Andrew Bartlett



Revisions:
client.h		1.46.2.10 => 1.46.2.11
	http://www.samba.org/cgi-bin/cvsweb/samba/source/include/client.h.diff?r1=1.46.2.10&r2=1.46.2.11
ntlmssp.h		1.2.2.7 => 1.2.2.8
	http://www.samba.org/cgi-bin/cvsweb/samba/source/include/ntlmssp.h.diff?r1=1.2.2.7&r2=1.2.2.8
rpc_dce.h		1.22.2.7 => 1.22.2.8
	http://www.samba.org/cgi-bin/cvsweb/samba/source/include/rpc_dce.h.diff?r1=1.22.2.7&r2=1.22.2.8



More information about the samba-cvs mailing list