CVS update: samba/source/rpcclient

[Tim Potter]

On Fri, Jan 17, 2003 at 10:21:22AM +0100, Jean Francois Micouleau wrote:

> depending on how the string is passed (data or ptr), on the pipe (LSA
> comes to mind), and the phase of the moon and the different SP, all the
> unicode strings are not equal !
> 
> Some strings are raw strings (not NULL terminated), max length=length
> some can be terminated max len=len including the NULL
> some can be not terminated but max len=len+1
> 
> then you have the LSA case where they reimplemented their unicode support

I don't think it's really reimplemented, just badly written IDL.  The 
16-bit lengths are just length_is and size_is attributes, i.e counted
strings.

> I *like* that stuff, 4 teams, 4 different implementations, they have yet a
> long way to go before give advices on code quality :)

Yes, all the IDLs seem to have been written by people with wildly different
styles.  I've discovered some char * (instead of wchar *)arrays in the DNS 
pipe!


Tim.