CVS update: samba/source/python

jra at dp.samba.org jra at dp.samba.org
Fri Jan 17 16:44:15 EST 2003


On Thu, Jan 16, 2003 at 11:58:43PM -0500, tridge at samba.org wrote:
> 
> Modified Files:
> 	py_spoolss_forms.c py_spoolss_forms_conv.c 
> Log Message:
> This removes the 3rd argument from init_unistr2(). There were 240
> calls to init_unistr2() in the code and every one of them got the 3rd
> argument incorrect, so I thought it best just to remove the argument.
> 
> The incorrect usage was caused by callers using strlen() to determine
> the length of the string. The 3rd argument to init_unistr2() was
> supposed to be the character length, not the byte length of the
> string, so for non-english this could come out wrong.
> 
> I also removed the bogus 'always allocate at least 256 bytes'
> hack. There may be some code that relies on this, but if there is then
> the code is broken and needs fixing. 

Please merge with 3.0 :-).

Jeremy.



More information about the samba-cvs mailing list