CVS update: samba/source/rpc_server

tridge at samba.org tridge at samba.org
Fri Jan 17 15:58:45 EST 2003


Date:	Fri Jan 17 04:58:45 2003
Author:	tridge

Update of /home/cvs/samba/source/rpc_server
In directory dp.samba.org:/tmp/cvs-serv3428/rpc_server

Modified Files:
	srv_dfs_nt.c srv_lsa_nt.c srv_samr_nt.c srv_spoolss_nt.c 
Log Message:
This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing. 



Revisions:
srv_dfs_nt.c		1.15 => 1.16
	http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_dfs_nt.c?r1=1.15&r2=1.16
srv_lsa_nt.c		1.62 => 1.63
	http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_lsa_nt.c?r1=1.62&r2=1.63
srv_samr_nt.c		1.136 => 1.137
	http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_samr_nt.c?r1=1.136&r2=1.137
srv_spoolss_nt.c		1.374 => 1.375
	http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_spoolss_nt.c?r1=1.374&r2=1.375



More information about the samba-cvs mailing list