CVS update: samba/source/lib

abartlet at samba.org abartlet at samba.org
Mon Feb 17 23:27:34 EST 2003


Date:	Mon Feb 17 12:27:34 2003
Author:	abartlet

Update of /data/cvs/samba/source/lib
In directory dp.samba.org:/tmp/cvs-serv24255/lib

Modified Files:
	username.c util_str.c 
Log Message:
This patch fixes one of my longest-standing pet hates with Samba :-).

When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the 
members of a group.

I'm sure this will fix some nasty performance issues, particularly on large 
domains etc.  In particular, this avoids contacting winbind at all, if the
group is not a winbind group.

(This caused a deadlock on my winbind-on-PDC setup).

The groups list always includes the user's primary group, as per the 
getgrouplist manpage, and my recent changes to our implementation.

Andrew Bartlett


Revisions:
username.c		1.74 => 1.75
	http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/username.c?r1=1.74&r2=1.75
util_str.c		1.77 => 1.78
	http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/util_str.c?r1=1.77&r2=1.78


More information about the samba-cvs mailing list