CVS update: samba/source/libsmb

[Volker Lendecke]

On Sat, Sep 28, 2002 at 09:58:38AM +1000, Andrew Bartlett wrote:
> This patch looks wrong.

Ok, the function was wrong before. The first cli_push_string is simply not
needed. It was there before, I did not look closely enough to notice that it's
redundant.

> Why is the password being cli_push_string()ed twice, and why is it any
> different to any other string in Samba (which gets made unicode
> automaticly as required).

cli_push_string calls push_string directly, simply passing though the 'flags'.
These flags say which charset the target string is in. So the call to
cli_push_string has to say itself whether there should be unicode on the wire
or not. The problem I see here is that this might be samba-only behaviour. I do
not know any proprietary server that does unicode and plaintext passwords.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 240 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-cvs/attachments/20020928/12ea4013/attachment.bin