CVS update: samba/source/libsmb

Andrew Bartlett abartlet at samba.org
Sat Sep 28 09:58:38 EST 2002


vlendec at samba.org wrote:
> 
> Date:   Fri Sep 27 16:51:22 2002
> Author: vlendec
> 
> Update of /data/cvs/samba/source/libsmb
> In directory dp.samba.org:/tmp/cvs-serv28887
> 
> Modified Files:
>         cliconnect.c
> Log Message:
> Touching somebody else's code again... Sorry, Richard.
> 
> smbclient would announce that it can send UNICODE, but would send the
> plain text password in ASCII. This confused Samba HEAD somewhat. This
> change has been tested against Samba HEAD of today and Samba 2.2.1a. I
> do not have any other servers that do plain text passwords. Anybody?

This patch looks wrong.

Why is the password being cli_push_string()ed twice, and why is it any
different to any other string in Samba (which gets made unicode
automaticly as required).

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net



More information about the samba-cvs mailing list