CVS update: samba/source/rpc_parse

Simo Sorce idra at samba.org
Sat Sep 14 02:00:49 EST 2002


Yes seem nicer, would you like to commit it?
Simo.

On Fri, 2002-09-13 at 17:41, REILLY,JOHN R (HP-Roseville,ex1) wrote:
> Its just a style thing, but it seems to me that something like:
> 
>   #define ALIGN(x,r) ((x + (r-1)) & ~(r-1))
> 
> would allow easier reading:
> 
> -	size += size % 4;
> +	size = ALIGN(size, 4);
> 
> vs..
> 
> -	size += size % 4;
> +	if ((size % 4) != 0) {
> +		size += 4 - (size % 4);
> +	}
>  
> Cheers
> JohnR
> 
> -----Original Message-----
> From: idra at samba.org [mailto:idra at samba.org]
> Sent: Fri 13-Sep-02 1:54am
> To: samba-cvs at samba.org
> Subject: CVS update: samba/source/rpc_parse
> 
> 
> 
> Date:	Fri Sep 13 08:53:53 2002
> Author:	idra
> 
> Update of /data/cvs/samba/source/rpc_parse
> In directory dp.samba.org:/tmp/cvs-serv28002
> 
> Modified Files:
> 	parse_spoolss.c 
> Log Message:
> 
> wrong alignment size calculation
> spot by Florian Weimer <Weimer at CERT.Uni-Stuttgart.DE>
> 
> 
> 
> Revisions:
> parse_spoolss.c		1.188 => 1.189
> 	
> http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_parse/parse_spoolss.c?r
> 1=1.188&r2=1.189
-- 
Simo Sorce - idra at samba.org
Samba Team - http://www.samba.org



More information about the samba-cvs mailing list