CVS update: samba/source/rpc_server

Gerald Carter jerry at samba.org
Mon Sep 9 23:13:26 EST 2002


On Mon, 9 Sep 2002 jra at samba.org wrote:

> 
> Date:	Mon Sep  9 06:44:29 2002
> Author:	jra
> 
> Update of /data/cvs/samba/source/rpc_server
> In directory dp.samba.org:/tmp/cvs-serv5119/rpc_server
> 
> Modified Files:
> 	srv_spoolss_nt.c 
> Log Message:
> Actually, I think Jerrys patch was incorrect as it didn't ever
> add the printing msg flag, only remove it. Also, we already

This was wrong.  It did add the "printing msg flag".  Was change 
notify not working for you?

> refcount the printer backchannel connection to add the connection
> tdb flag just before after we register/deregister the notification
> message handler.
> Jerry please check !
> Jeremy.

OK.  I see what you did.  That looks fine.  However, it would probably be 
better for my blood pressure and my sanity if you had said "cleaned up 
patch since we already maintain a reference counter for the cli_connection 
struct".  The word "incorrrect" sent me off into a tizzy 'cause it was 
working.

As long as you tested you change.... :-)




cheers, jerry
 ---------------------------------------------------------------------
 Hewlett-Packard                                     http://www.hp.com
 SAMBA Team                                       http://www.samba.org
 --                                            http://www.plainjoe.org
 "Sam's Teach Yourself Samba in 24 Hours" 2ed.      ISBN 0-672-32269-2
 --"I never saved anything for the swim back." Ethan Hawk in Gattaca--




More information about the samba-cvs mailing list