CVS update: samba/source/rpc_server

[Andrew Bartlett]

jra at dp.samba.org wrote:
> 
> On Thu, Sep 05, 2002 at 02:49:09AM -0400, tpot at samba.org wrote:
> >
> > Date: Thu Sep  5 06:49:09 2002
> > Author:       tpot
> >
> > Update of /data/cvs/samba/source/rpc_server
> > In directory dp.samba.org:/tmp/cvs-serv20356/rpc_server
> >
> > Modified Files:
> >       srv_spoolss_nt.c
> > Log Message:
> > Delivery notify messages over the back channel in *reverse* order in
> > which they are sent in the message.  This is because a DLIST_ADD is
> > used by the message sender which results in the first (post!) message
> > being at the end of the list.  Notify messages must be delivered in
> > the order the events occur in otherwise the port monitor gets
> > confused.
> >
> >
> > Revisions:
> > srv_spoolss_nt.c              1.334 => 1.335
> >       http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_spoolss_nt.c?r1=1.334&r2=1.335
> 
> Tim - why do this ? Why not add the entries to the end of the
> list using DLIST_ADD_END ?
> 
> I'm going to code this up in the sender and remove this code...

I have to agree - 'knowing' that a list is backwards is just going to
lead to bugs...  

Andrew,

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net