CVS update: samba/source/rpc_parse

Tim Potter tpot at samba.org
Tue Sep 3 06:24:58 EST 2002


On Mon, Sep 02, 2002 at 09:25:55AM -0500, Gerald Carter wrote:

> > Did some trickyness to get enumprinterdataex replies unmarshalled
> > properly.  The code seems to have been written to require the number of
> > entries returned before unpacking said entries.  Skip to the end of the
> > response and read the number of entries then jump back and process the
> > printer data.
> 
> This looks ok, but you did test the server code after you made 
> the changes right?  Sorry, but I'm a little paranoid about this 
> code since it took me longer than it should have to work correctly....

I did - we don't seem to return anything for key = PrinterDriverData.  
Are we supposed to?  The request/response returned looked OK.

These are all part of the unit testing framework anyway.  (-:


Tim.



More information about the samba-cvs mailing list