CVS update: samba/source/smbd

jra at dp.samba.org jra at dp.samba.org
Sun Sep 1 22:53:38 EST 2002


On Sat, Aug 31, 2002 at 10:56:06PM +1000, Andrew Bartlett wrote:
> jra at samba.org wrote:
> > 
> > Date:   Fri Aug 30 15:29:59 2002
> > Author: jra
> > 
> > Update of /data/cvs/samba/source/smbd
> > In directory dp.samba.org:/tmp/cvs-serv536/smbd
> > 
> > Modified Files:
> >         open.c
> > Log Message:
> > Fix bug with stat mode open being done on read-only open with
> > truncate.
> > Jeremy.
> > 
> > Revisions:
> > open.c          1.120 => 1.121
> >         http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/open.c?r1=1.120&r2=1.121
> 
> I think this is what has causes us to 'fail' the OPEN smbtorture test
> (which we run on the build farm).
> 
> Any chance you can look at it?  I presume it's just a matter of bringing
> smbtorture into line with the new reality...

Actually no, it isn't the bug (it was a new one :-). We "fail"
the OPEN smbtorture test because I discovered (via the IFSTEST)
the doing an NTCreateX with mismatching attributes for HIDDEN
and SYSTEM should cause access denied. By default we don't map
hidden or system so in order to pass this we must set the create
mask to 0777 and turn on mapping of hidden and system. This is
only a "fail" in the same way we "fail" strict read/write locking
unless strict locking is enabled.

But I wanted to have the test in smbtorture for other vendors :-).
Plus we do pass with the above turned on :-).

Cheers,

	Jeremy.



More information about the samba-cvs mailing list