CVS update: samba/source/smbd

[Andrew Bartlett]

On Sat, 2002-11-09 at 15:46, jra at dp.samba.org wrote:
> On Sat, Nov 09, 2002 at 03:44:23PM +1100, Andrew Bartlett wrote:
> > On Sat, 2002-11-09 at 15:20, jra at samba.org wrote:
> > > 
> > > Date:	Sat Nov  9 04:20:22 2002
> > > Author:	jra
> > > 
> > > Update of /data/cvs/samba/source/smbd
> > > In directory dp.samba.org:/tmp/cvs-serv3997/smbd
> > > 
> > > Modified Files:
> > >       Tag: APPLIANCE_HEAD
> > > 	password.c 
> > > Log Message:
> > > Fix for auth aspects of CR#1100. Holds domain mutex longer. 
> > 
> > For that mutex:  I think we should split it in two, and hold the Win2k
> > dropout prevention one in libsmb/cliconnect.c, rather than in each
> > caller.  
> > 
> > I've had a patch in my 'too look at' queue for an age to add this to
> > winbindd, which could step in at just the wrong moment, but never got a
> > chance test it.  (and I do like my patches at least lightly tested...).
> > 
> > What do you think?
> 
> Can you send the patch to me please ?
> 
> If it looks good - it will *definately* get tested :-).

Not to worry, it looks like somebody else added in the mutex - I never
looked at the code that closely, I just kept seeing it in one of my less
used CVS trees :-).

But anyway, I still think that we should move all this mutex stuff into
cli_full_connection().  That way we pick up *all* connections, not just
those that happen to be from places we think might be racing us.  Now we
can't pick up unprivileged users here, but it's better than nothing.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-cvs/attachments/20021109/f2065a48/attachment.bin