CVS update: samba/source/passdb

[jra at dp.samba.org]

On Thu, Nov 07, 2002 at 06:18:22PM +1100, Andrew Bartlett wrote:
> On Thu, 2002-11-07 at 15:52, tridge at samba.org wrote:
> > 
> > Date:	Thu Nov  7 04:52:04 2002
> > Author:	tridge
> > 
> > Update of /home/cvs/samba/source/passdb
> > In directory dp.samba.org:/tmp/cvs-serv12371
> > 
> > Modified Files:
> > 	passdb.c 
> > Log Message:
> > when doing a 'net rpc vampire' a pdb_init_sam_pw() is used to create a
> > sam account object, then pdb_update_sam_account() can be used to
> > update an account. This code path could lead to the methods element of
> > the account being used when uninitialised (leading to a segv)
> > 
> > Easiest fix is to always make that that when creating a sam_account
> > object we initialise the methods to null, so that the passdb code
> > knows that it needs to be filled in.
> 
> Nice (and correct) fix.  

Yeah, just wished he'd bothered to check it into 3.0 as well.
You know... the branch we want to *ship* :-).

Jeremy.

(Who is feeling in a pissy mood this evening :-).