CVS update: samba/source/passdb

abartlet at samba.org abartlet at samba.org
Tue Mar 19 16:53:38 EST 2002


On Mon, Mar 18, 2002 at 03:57:14PM -0800, Simo Sorce wrote:
> 
> Date:	Mon Mar 18 15:57:14 2002
> Author:	idra
> 
> Update of /data/cvs/samba/source/passdb
> In directory va:/tmp/cvs-serv2831/source/passdb
> 
> Modified Files:
> 	pdb_get_set.c pdb_tdb.c 
> Log Message:
> more verbose checking in talloc and util_pw
> fixed tdbsam memory corruption (and segfault)
> reducing calls to pdb_uid_to_user_rid and countrary to 0 to move to a non alghoritmic rid allocation with some passdb modules.

Thanks for doing this, but I don't think this is quite correct...

What we need to do (and I'll do if you don't have the time) is convert this to 
call 'sid_to_uid' and 'uid_to_sid'.  

I'm saying this on the basis that winbind (domain) users are allowd to be 
members of and NT alias, (a unix local group).

If this is the case, we should modify local_uid_to_sid is the way you modifed 
these functions, and make use of my existing code by calling sid_to_uid 
(and therefore local_sid_to_uid) in the converse case.

(see the the use of 'sid_split_rid' and 'sid_append_rid' in the samr code for where to get the SID from/to)

Thanks!

Andrew Bartlett 




More information about the samba-cvs mailing list