CVS update: samba/source/rpc_parse
Tim Potter
tpot at samba.org
Wed Jun 26 10:26:07 EST 2002
On Tue, Jun 25, 2002 at 05:15:16PM -0700, jerry at samba.org wrote:
> Update of /data/cvs/samba/source/rpc_parse
> In directory va:/tmp/cvs-serv15730/rpc_parse
>
> Modified Files:
> Tag: APPLIANCE_HEAD
> parse_misc.c parse_sec.c
> Log Message:
> removing all prs_align() calls from marshalling up security
> descriptors. This appears to fix a failure in the PSA functionality
> tests. Needs much more testing with file sec-desc to ensure
> it hasn't broken anythign inadvertantly. That will come tomorrow. :-)
>
> Will merge into HEAD after I've spent more time in testing....
The change to parse_misc.c is OK - uint8's require no alignment.
However in parse_sec.c there should be alignments to a 2-byte boundary
before the prs_uint16 calls. This probably just works anyway because
the offsets have probably been constructed with the correct alignment.
I think you still need the prs_align() for sec_io_access though.
Tim.
More information about the samba-cvs
mailing list