CVS update: samba/source/libsmb

Andrew Bartlett abartlet at pcug.org.au
Sat Jun 1 10:15:48 EST 2002


Jeremy Allison wrote:
> 
> Date:   Fri May 31 17:10:08 2002
> Author: jra
> 
> Update of /data/cvs/samba/source/libsmb
> In directory va:/tmp/cvs-serv10831/libsmb
> 
> Modified Files:
>         cli_lsarpc.c cliconnect.c
> Log Message:
> More cleanup work preparing for SMB signing.
> Jeremy.

 
+	/* Guest cannot use SMB signing. */
+	cli->sign_info.use_smb_signing = False;
+

This looks wrong.

The test for SMB signing should be that the server returned a session
setup with the signiture feild filled in.  As far as I read it, opening
up a guest session before *or* after the 'real' session setup should not
affect signing.  

(it should just default to 'not done yet' and move to 'must sign' when
both parties have signed their packets.)

Andrew Bartlett,

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-cvs mailing list