CVS update: samba/source/rpc_server

[Andrew Bartlett]

jerry at samba.org wrote:
> 
> Date:   Wed Jul  3 12:15:26 2002
> Author: jerry
> 
> Update of /data/cvs/samba/source/rpc_server
> In directory va:/tmp/cvs-serv10050/rpc_server
> 
> Modified Files:
>         srv_reg.c srv_reg_nt.c
> Log Message:
> first cut at implementing support for browsing printer and driver driver
> via regedt32.exe.  The regsitry.tdb is only a framework.  It is not
> intended to store values, only key/subkey structure.  The data
> will be retrieved from nt*tdb (for printers) creating a virtual view
> of the data.

> Revisions:
> srv_reg.c               1.36 => 1.37
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_reg.c?r1=1.36&r2=1.37
> srv_reg_nt.c            1.18 => 1.19
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_reg_nt.c?r1=1.18&r2=1.19

Sorry to get picky, but I do have some further comments:

 - You seem to be using a *lot* of pstrings.  Can we make these
allocated?  (This is meant to be the general trend with new code in
Samba - or so I'm told...)

- Can we move the generic 'manipulate registry' functions out of
rpc_server?

Functions like this:

+/***********************************************************************
+ Open the registry database
+
***********************************************************************/
+ 
+BOOL init_registry( void )

Just make it harder to modulise the code.  Remeber how jmcd tried to
read printing TDBs for 'net'?  I would like to see a command line
regedit tool (it makes testing this stuff *much* easier) and it would be
nice to avoid bringing in *.o.

Other than that, it looks pretty neat!  I do think we will end up
needing to store actual data at some point, but I see no reason that
can't be added.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net