CVS update: samba/source/rpc_server

[Andrew Bartlett]

jerry at samba.org wrote:
> 
> Date:   Wed Jul  3 12:15:26 2002
> Author: jerry
> 
> Update of /data/cvs/samba/source/rpc_server
> In directory va:/tmp/cvs-serv10050/rpc_server
> 
> Modified Files:
>         srv_reg.c srv_reg_nt.c
> Log Message:
> first cut at implementing support for browsing printer and driver driver
> via regedt32.exe.  The regsitry.tdb is only a framework.  It is not
> intended to store values, only key/subkey structure.  The data
> will be retrieved from nt*tdb (for printers) creating a virtual view
> of the data.
> 
> You can currently connect to a Samba box using regedt32.exe (haven't
> tried regedit.exe).  Some basic keys are created in registry.tdb
> for use.
> 
> There are two problems....
> 
>   * something is getting freed in the winreg code that causes heap
>     corruption later on.  As long as you don't play with the winreg
>     server functionality, I don't think you'll be bitten by this.

Watch out, a hell of a lot of stuff calls the registry (domain join in
particular) so be careful...  Most of it takes 'failure' fine, but we
will need to watch what happens when it starts to succeed.

>   * no access controls are currently implemented
> 
>   * I can't browse HKLM because regedt32 greys out the SYSTEM subkey.
> 
> ok so that was three....

Why the use of void*?  

+static BOOL store_reg_keys( TDB_CONTEXT *tdb, char *keyname, char
**subkeys, uint32 num_subkeys  )
+{
+       TDB_DATA kbuf, dbuf;
+       void *buffer, *tmpbuf;
             ^        ^  

The tdbpack code uses a char*, and ./configure --enable-krb5developer
doesn't like the void* artihmatic.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net