CVS update: samba/source/lib
Andrew Bartlett
abartlet at pcug.org.au
Fri Jan 25 11:42:03 EST 2002
Simo Sorce wrote:
>
> Date: Thu Jan 24 16:35:14 2002
> Author: idra
>
> Update of /data/cvs/samba/source/lib
> In directory va:/tmp/cvs-serv18395/lib
>
> Modified Files:
> util.c util_str.c
> Log Message:
> minor fixes
if (!p) p = ns;
- memmove(p, t, (strlen_w(t) + 1) *
sizeof(smb_ucs2_t));
+ if (*t == 0) *p = 0;
+ else memmove(p, t, (strlen_w(t) + 1) *
sizeof(smb_ucs2_t));
t = p;
}
Yes, its perfectly valid C. It is also rather difficult to read...
Any chance you could either add brackets or at least put each component
on a new line? (The same probably applies to the rest of the function
as well...)
Andrew Bartlett
--
Andrew Bartlett abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team abartlet at samba.org
Student Network Administrator, Hawker College abartlet at hawkerc.net
http://samba.org http://build.samba.org http://hawkerc.net
More information about the samba-cvs
mailing list