CVS update: samba/source/printing

Tim Potter tpot at samba.org
Wed Jan 23 13:44:19 EST 2002


On Wed, Jan 23, 2002 at 01:23:46PM +1100, Andrew Bartlett wrote:

> > Revisions:
> > nt_printing.c           1.96.2.92 => 1.96.2.93
> >         http://www.samba.org/cgi-bin/cvsweb/samba/source/printing/nt_printing.c?r1=1.96.2.92&r2=1.96.2.93
> 
> -               if (owner_rid != BUILTIN_ALIAS_RID_PRINT_OPS &&
> -                   owner_rid != BUILTIN_ALIAS_RID_ADMINS &&
> -                   owner_rid != DOMAIN_USER_RID_ADMIN &&
> -                   !lookup_name("root", &owner_sid, &name_type)) {
> -                       sid_copy(&owner_sid, &global_sid_World);
> +               if (!lookup_name("root", &owner_sid, &name_type)) {
> +                       sid_copy(&owner_sid, &global_sam_sid);
> +                       sid_append_rid(&owner_sid,
> DOMAIN_USER_RID_ADMIN);
>                 }
>         }
>  
> As a matter of interest:  Why do we have a magic 'root' here?

Actually we can probably nuke the lookup_name and replace the backup
plan with the sid_copy and the sid_append_rid.


Tim.




More information about the samba-cvs mailing list