CVS update: samba/source/printing

Andrew Bartlett abartlet at pcug.org.au
Wed Jan 23 13:23:46 EST 2002


Jeremy Allison wrote:
> 
> Date:   Tue Jan 22 18:02:24 2002
> Author: jra
> 
> Update of /data/cvs/samba/source/printing
> In directory va:/tmp/cvs-serv4022/printing
> 
> Modified Files:
>       Tag: SAMBA_2_2
>         nt_printing.c
> Log Message:
> Insure fixes.
> Jeremy.
> 
> Revisions:
> nt_printing.c           1.96.2.92 => 1.96.2.93
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/printing/nt_printing.c?r1=1.96.2.92&r2=1.96.2.93

-               if (owner_rid != BUILTIN_ALIAS_RID_PRINT_OPS &&
-                   owner_rid != BUILTIN_ALIAS_RID_ADMINS &&
-                   owner_rid != DOMAIN_USER_RID_ADMIN &&
-                   !lookup_name("root", &owner_sid, &name_type)) {
-                       sid_copy(&owner_sid, &global_sid_World);
+               if (!lookup_name("root", &owner_sid, &name_type)) {
+                       sid_copy(&owner_sid, &global_sam_sid);
+                       sid_append_rid(&owner_sid,
DOMAIN_USER_RID_ADMIN);
                }
        }
 
As a matter of interest:  Why do we have a magic 'root' here?

I'm trying to implement 'non unix accounts' in HEAD, and this is the
only call for 'lookup_name' outside srv_samr_nt.c and srv_samr_lsa.c -
It would be nice to kill it off.  (to acheive this I'm doing to passdb
lookup before a getpwnam based lookup in passdb.c:local_lookup_name -
and taking the supplied RID).

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-cvs mailing list