CVS update: samba/source/rpc_server

[Jeremy Allison]

On Mon, Jan 21, 2002 at 08:40:24PM -0800, jreilly at samba.org wrote:
> 
> Date:	Mon Jan 21 20:40:24 2002
> Author:	jreilly
> 
> Update of /data/cvs/samba/source/rpc_server
> In directory va:/tmp/cvs-serv14078/rpc_server
> 
> Modified Files:
>       Tag: APPLIANCE_HEAD
> 	srv_spoolss_nt.c 
> Log Message:
> The semantics of c_setprinter are now finally correct. What was M$ thinking?
> 
> Modified change_id code to match the wire. It is msec since the spooler started. Thanks to
> Jeremy and Jerry for figuring this out.
> 
> Modified things to work properly with 2k. Although the W32API use PRINTER_INFO_8 to set a
> DEVMODE, it actually is PRINTER_INFO_2 on the wire. Now we can get rid of the SetPrinterData
> to a magic registry key (replaced by some other less ugly stuff, sigh).
> 
> Changed printer notifies to just send changes related to things that changed... well mostly.
> Jerry - we still need to look into whether this need to be exactly what changed.
> 
> Modified Jeremy's patch to notification handles to work correctly (No, I didn't find a bug in
> his code... I explained the problem to him poorly). Jeremy - please port this to 2.2, what is
> there doesn't work correctly.

I'm not going to port this immediately. I need to talk to you
about this. The code you modified will only send notifications to the current
process, any other process receiving the message will ignore it.

I don't think this is correct. Looking at the change you've
made I understand the issue (I'm sending a notification on
the wrong handle). I'll fix this for 2.2 and HEAD.

But I still think all other smbd's need to get the printer
name in order to send an asynchronous notification.

Jeremy.