CVS update: samba/source/groupdb

abartlet at samba.org abartlet at samba.org
Thu Jan 17 19:45:53 EST 2002


Date:	Thu Jan 17 00:45:53 2002
Author:	abartlet

Update of /data/cvs/samba/source/groupdb
In directory va:/tmp/cvs-serv1392/groupdb

Modified Files:
	mapping.c 
Log Message:
A nice *big* change to the fundemental way we do things. 

Samba (ab)uses the returns from getpwnam() a lot - in particular it keeps 
them around for a long time - often past the next call...

This adds a getpwnam_alloc and a getpwuid_alloc to the collection.

These function as expected, returning a malloced structure that can be 
free()ed with passwd_free(&passwd).

This patch also cuts down on the number of calls to getpwnam - mostly by 
taking advantage of the fact that the passdb interface is already 
case-insensiteve.

With this patch most of the recursive cases have been removed (that I know
of) and the problems are reduced further by not using the sys_ interface
in the new code.  This means that pointers to the cache won't be affected. 
(This is a tempoary HACK, I intend to kill the password cache entirly).

The only change I'm a little worried about is the change to 
rpc_server/srv_samr_nt.c for private groups.  In this case we are getting 
groups from the new group mapping DB.  Do we still need to check for private 
groups?  I've toned down the check to a case sensitve match with the new code,
but we might be able to kill it entirly.

I've also added a make_modifyable_passwd() function, that copies a passwd 
struct into the form that the old sys_getpw* code provided.  As far as I can
tell this is only actually used in the pass_check.c crazies, where I moved 
the final 'special case' for shadow passwords (out of _Get_Pwnam()).

The matching case for getpwent() is dealt with already, in lib/util_getent.c

Also included in here is a small change to register the [homes] share at vuid
creation rather than just in one varient of the session setup.  (This picks 
up the SPNEGO cases).  The home directory is now stored on the vuid, and I
am hoping this might provide a saner way to do %H substitions.

TODO:  Kill off remaining Get_Pwnam_Modify calls (they are not needed), change
the remaining sys_getpwnam() callers to use getpwnam_alloc() and move 
Get_Pwnam to return an allocated struct.

Andrew Bartlett


Revisions:
mapping.c		1.29 => 1.30
	http://www.samba.org/cgi-bin/cvsweb/samba/source/groupdb/mapping.c?r1=1.29&r2=1.30




More information about the samba-cvs mailing list