CVS update: samba/source/nsswitch

Herb Lewis herb at sgi.com
Wed Jan 16 08:13:15 EST 2002


"Jim McDonough (IBM)" wrote:
> 
> Date:   Tue Jan 15 09:58:59 2002
> Author: jmcd
> 
> Update of /home/cvs/samba/source/nsswitch
> In directory va:/tmp/cvs-serv9774
> 
> Modified Files:
>         winbindd_wins.c
> Log Message:
> Fix from 2.2.  It didn't break on HEAD because it isn't being compiled.  Herb?
> 
> Revisions:
> winbindd_wins.c         1.1 => 1.2
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/nsswitch/winbindd_wins.c?r1=1.1&r2=1.2

The 2.2 fix is completely broken. The final argument to safe_strcat is
the max string length not the size of the string you are adding. I have
another small change as well so I'll be checking in the fix to the
2.2 branch.

I haven't added the other stuff to HEAD because I wanted to make sure
it worked in 2.2 first. This was a new file and I wasn't sure if cvs
would complain about adding it to the branch first so I just added the
same file to head for safety.

For some reason my email is very slow so I just now saw this commit
message but still haven't seen the 2.2 one. It took me a while to 
find why my latest build core dumped winbindd when I didn't notice
the update to the file and I didn't make any changes.

-- 
======================================================================
Herb Lewis                               Silicon Graphics 
Networking Engineer                      1600 Amphitheatre Pkwy MS-510
Strategic Software Organization          Mountain View, CA  94043-1351
herb at sgi.com                             Tel: 650-933-2177
http://www.sgi.com                       Fax: 650-932-2177          
======================================================================




More information about the samba-cvs mailing list