CVS update: samba/source/passdb

Andrew Bartlett abartlet at pcug.org.au
Wed Jan 16 09:43:01 EST 2002


Gerald Carter wrote:
> 
> On Mon, 14 Jan 2002 abartlet at samba.org wrote:
> 
> > The pdb_init_sam and pdb_free_sam functions now also return an
> > NTSTATUS, and I have modified the 3 places that actually checked these
> > returns.
> >
> > The only nasty thing about this patch is the small measure needed to
> > maintin interface compatability - strings set to NULL are actually set
> > to "".
> >
> > This is becouse there are too many places in Samba that do strlen() on
> > these strings without checking if they are NULL pointers.
> >
> > A supp patch will follow to set all strings to "" in
> > pdb_default_sam().
> 
> Wny not just define more FLAG_SAM_XXX bitmasks? and use IS_SAM_SET()?

That is exactly how is should be done - the problem is that I didn't get
a chance to work around all the places where we do
strlen(pdb_get_....()).  This way I don't get any segfaults and the
interface (horrid as it is) remains constant.

I just didn't get time to both do and test this and to grep the rest of
the source for offending code...

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-cvs mailing list