CVS update: samba/source/libsmb
Tim Potter
tpot at samba.org
Thu Jan 3 20:05:08 EST 2002
On Thu, Jan 03, 2002 at 09:59:54AM +0100, Jean Francois Micouleau wrote:
> > Modified Files:
> > cli_spoolss.c
> > Log Message:
> > The werror<->nt status code map has changed and has broken all the spoolss
> > commands in rpcclient. Replacing ERROR_INSUFFICIENT_BUFFER with
> > NT_STATUS_BUFFER_TOO_SMALL fixes it. Yay!
> >
> > I always thought the caller (i.e cmd_spoolss.c) should take care of the
> > whole requested/needed buffer size thingy though...
>
> yes it should. that's not the cli_spoolss.c job to re-issue command if the
> buffer was too small.
OK - I'll fix it up when I get a chance. So, as a matter of form do
you prefer:
a) doing a call with zero length buffer then making a second call
with the right buffer size
or
b) doing a call with a buffer size of 100 (the default at the
moment) and then re-issuing the call if that is too small
The first option will always take two round trips but the first trip
is always a short one. The second option can complete in only one
trip.
Tim.
More information about the samba-cvs
mailing list