CVS update: samba/source/smbd

Martin Pool mbp at samba.org
Tue Feb 26 14:09:12 EST 2002


Date:	Mon Feb 25 19:09:12 2002
Author:	mbp

Update of /data/cvs/samba/source/smbd
In directory va:/tmp/cvs-serv4160/smbd

Modified Files:
      Tag: SAMBA_2_2
	lanman.c reply.c 
Log Message:
[merge from APPLIANCE_HEAD]

"constants aren't, safe_strcat isn't."

This patch tries to fix a bug in the lpq parsing code that causes a
crash in lprng and BSD parsers when there are long lines in the
output.  A too-short length parameter was passed to safe_strcat, which
provoked a signedness bug.

It also makes the lpq parser consistently use fstring routines, rather
than its own hand-crafted strlen/sizeof guff.  Some variables were
renamed to make this obvious.

Finally safe_strcat is changed so that it actually does handle the
situation where strlen(dest)>maxlen, rather than crying for help by
clobbering -1 bytes of memory.

(HP CR #430)


Revisions:
lanman.c		1.22.2.29 => 1.22.2.30
	http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/lanman.c?r1=1.22.2.29&r2=1.22.2.30
reply.c		1.240.2.94 => 1.240.2.95
	http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/reply.c?r1=1.240.2.94&r2=1.240.2.95




More information about the samba-cvs mailing list