CVS update: samba/source/rpc_server
Martin Pool
mbp at samba.org
Tue Feb 26 14:09:11 EST 2002
Date: Mon Feb 25 19:09:11 2002
Author: mbp
Update of /data/cvs/samba/source/rpc_server
In directory va:/tmp/cvs-serv4160/rpc_server
Modified Files:
Tag: SAMBA_2_2
srv_spoolss_nt.c
Log Message:
[merge from APPLIANCE_HEAD]
"constants aren't, safe_strcat isn't."
This patch tries to fix a bug in the lpq parsing code that causes a
crash in lprng and BSD parsers when there are long lines in the
output. A too-short length parameter was passed to safe_strcat, which
provoked a signedness bug.
It also makes the lpq parser consistently use fstring routines, rather
than its own hand-crafted strlen/sizeof guff. Some variables were
renamed to make this obvious.
Finally safe_strcat is changed so that it actually does handle the
situation where strlen(dest)>maxlen, rather than crying for help by
clobbering -1 bytes of memory.
(HP CR #430)
Revisions:
srv_spoolss_nt.c 1.115.2.157 => 1.115.2.158
http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_spoolss_nt.c?r1=1.115.2.157&r2=1.115.2.158
More information about the samba-cvs
mailing list