CVS update: samba/source/printing
Martin Pool
mbp at samba.org
Tue Feb 26 12:17:00 EST 2002
Date: Mon Feb 25 17:16:59 2002
Author: mbp
Update of /data/cvs/samba/source/printing
In directory va:/tmp/cvs-serv28864/printing
Modified Files:
Tag: APPLIANCE_HEAD
lpq_parse.c printing.c
Log Message:
"constants aren't, safe_strcat isn't."
This patch tries to fix a bug in the lpq parsing code that causes a
crash in lprng and BSD parsers when there are long lines in the
output. A too-short length parameter was passed to safe_strcat, which
provoked a signedness bug.
It also makes the lpq parser consistently use fstring routines, rather
than its own hand-crafted strlen/sizeof guff. Some variables were
renamed to make this obvious.
Finally safe_strcat is changed so that it actually does handle the
situation where strlen(dest)>maxlen, rather than crying for help by
clobbering -1 bytes of memory.
(HP CR #430)
Revisions:
lpq_parse.c 1.2.4.3 => 1.2.4.4
http://www.samba.org/cgi-bin/cvsweb/samba/source/printing/lpq_parse.c?r1=1.2.4.3&r2=1.2.4.4
printing.c 1.66.2.51 => 1.66.2.52
http://www.samba.org/cgi-bin/cvsweb/samba/source/printing/printing.c?r1=1.66.2.51&r2=1.66.2.52
More information about the samba-cvs
mailing list