CVS update: samba/source/utils

Andrew Bartlett abartlet at pcug.org.au
Sat Feb 9 23:05:31 EST 2002


herb at samba.org wrote:
> 
> Date:   Thu Feb  7 15:27:21 2002
> Author: herb
> 
> Update of /data/cvs/samba/source/utils
> In directory va:/tmp/cvs-serv19651
> 
> Modified Files:
>       Tag: SAMBA_2_2
>         smbpasswd.c
> Log Message:
> Add -c option to specify smb.conf file (-s was already used).
> This will allow you to use smbpasswd if your smb.conf file is not in
> the compiled location.
> 
> Move all the command line agrument processing to one place.

Do we really want to do this?

This means that smbpasswd will not complain when a normal user invokes
smbpasswd with 'useless' arguments.  They can't do any harm (not suid)
but with the old way we could give different useage messages and
different.  Sombody else killed off the seperate usage messages (meaning
a non-root user can see all the 'root only' options) already however...

> Process args before calling lp_load services so it gets correct smb.conf file
> 
> I'm not sure of the intent of the -L option (it no longer needs to be first).
> The usage message shows only root can use it, but there is no check in the
> original code to see if you were root before processing the arg. I left it
> so you can specify the arg as non-root but doesn't seem correct. Also
> this arg is not documented in smb.conf man page.

This 'magic' arg is to say 'I'm not root but pretend I am'.  I use it
extensivly becouse I run my samba test installation compleatly from
within my home dir, as abartlet.  I use root only for nmbd, and I think
I can inetd that as well.

Its wasn't documented due to its 'magic' status - its really only a
developers hack.

> Could people test the various forms of using smbpasswd to make sure I
> didn't break anything. I tried the ones I can think of and it seems OK.
> 
> Revisions:
> smbpasswd.c             1.93.2.24 => 1.93.2.25
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/smbpasswd.c?r1=1.93.2.24&r2=1.93.2.25

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-cvs mailing list