CVS update: samba/source/registry

Gerald Carter jerry at samba.org
Mon Aug 5 23:12:15 EST 2002


On Sun, 4 Aug 2002, Simo Sorce wrote:

> 
> Date:	Sun Aug  4 07:25:32 2002
> Author:	idra
> 
> Update of /data/cvs/samba/source/registry
> In directory va:/tmp/cvs-serv17057/registry
> 
> Modified Files:
> 	reg_db.c 
> Log Message:
> 
> commented out strupper before key check against internal db, it's no good
> to check for uppercased strings when we store them not uppercased.

This is wrong.  The string are uppercased.  You have an old version
of the regiostry.tdb file.  Delete it.  Please revert this change.




BOOL regdb_store_reg_keys( char *keyname, REGSUBKEY_CTR *ctr )
{
        TDB_DATA kbuf, dbuf;
        char *buffer, *tmpbuf;
        int i = 0;
        uint32 len, buflen;
        BOOL ret = True;
        uint32 num_subkeys = regsubkey_ctr_numkeys( ctr );

        if ( !keyname )
                return False;

        strupper_m( keyname  );
        ^^^^^^^^^^^^^^^^^^^^^^^



> jerry, this fix is needed to make usrmgr.exe work again.
> meanwhile we found out that NT_STATUS code may not be appropriate there.
> In particular it seem that an NT PDC will send back 02 as error
> (ERRbadfile) not 0xc000000f (NT_STATUS_NO_SUCH_FILE NT)
> 
> I think further investigation is need to understand which are aprropriate
> return codes here.

Probably so.  I didn't spend all that much time with error codes.





cheers, jerry





More information about the samba-cvs mailing list