2.2.2 Merging required: [Re: CVS update: samba/source/rpc_server]

Andrew Bartlett abartlet at pcug.org.au
Thu Sep 27 22:20:44 EST 2001


abartlet at samba.org wrote:
> 
> Date:   Thu Sep 27 02:13:26 2001
> Author: abartlet
> 
> Update of /data/cvs/samba/source/rpc_server
> In directory va:/tmp/cvs-serv14717/rpc_server
> 
> Modified Files:
>         srv_samr_nt.c
> Log Message:
> Fix memory leak in get_sampwd_entries(), reindent for clarity.
>  - call pdb_reset_sam() after each getent call.

Needs merge for 2.2.2

> Fix bug in get_group_alias_entries(), were if num_entries was zero this caused
> talloc() to return NULL, failing a test below with NT_STATUS_NO_MEMORY.
> 
> Fix pdb_reset_sam() to correctly initalise the sam structure.

Not urgent, but probably a good idea, depending on how far I'm
trusted...
 - current code assumes that ZERO_STRUCT() is a valid initilisation...
 
> Move default value code into a single place, likewise for sam freeing code.
>  - should make things easier if we decide to malloc other strings, or get more
>  non-zero default values.
> 
> Finally, add a function in init a sam struct from a getpwnam() return.

Only if your merging the rest
 
> Andrew Bartlett
> 
> Revisions:
> srv_samr_nt.c           1.44 => 1.45
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_samr_nt.c?r1=1.44&r2=1.45

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Samba Team member, Build Farm maintainer        abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-cvs mailing list