CVS update: samba/source/rpc_server

Andrew Bartlett abartlet at pcug.org.au
Thu Sep 6 23:46:21 EST 2001


Andrew Bartlett wrote:
> 
> Tim Potter wrote:
> >
> > Date:   Wed Sep  5 22:24:37 2001
> > Author: tpot
> >
> > Update of /data/cvs/samba/source/rpc_server
> > In directory va:/tmp/cvs-serv19772/rpc_server
> >
> > Modified Files:
> >         srv_netlog_nt.c
> > Log Message:
> > Logon workstation checks from Toomas Soome <tsoome at ut.ee>
> 
> Why are these checks being done here?  They don't belong here at all, as
> far as I can tell.  They belong inside the authenticaion subsystem,
> where they can be universally applied.  (That being the whole reason I'm
> working on this in the first place).  Or do these restricions not apply
> to file-share connections?
> 
> In this case its pretty trivial to fix, just see the #if 0'd part of
> _net_logon_any() for where I was going to implement it in future, and
> add the backend work to smbd/auth_smbpasswd.c
> 
> I would do this myself, but I'm a little snowed under.  (And I still
> can, if required).
> 
> Remember, the authenticaion subsusytem is fully NTSTATUS, so the correct
> code will be passed right back out to the wire.

Just in case there is any confusion, auth_smbpasswd.c really should be
renamed 'auth_samdb.c' or the like, it can do everything that the passdb
iterface provides.  I'll probably do it after I've got my other changes
settled/merged and or when passdb gets renamed to samdb (as discussed).

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Samba Team member, Build Farm maintainer        abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-cvs mailing list