CVS update: samba/source/rpc_parse

Tim Potter tpot at samba.org
Wed Oct 31 17:00:44 EST 2001


On Wed, Oct 31, 2001 at 04:27:57PM +1100, Andrew Bartlett wrote:

> > This one's a doozy.  A cut&paste bug incorrectly sets the max string length
> > of the lm challenge/response header in the NET_ID_INFO_2 structure included
> > in a network logon request.  It seems Windows 2000 is the only OS that
> > cares about this.
> 
> I'll put my hand up for that one, but don't you need to fix up the lm
> line as well?  
> 
> The original reason for the changes where to attempt to get NTLMv2
> support.  That of course can't work becouse the NT hashes are being
> castrated at 24 bytes.  (in the memcopy).
> 
> In the end I havn't had a chance to chase up our NTLMv2 status, but its
> probably broken.

This is really a bugfix for NTLMv1 only.  I haven't attempted to do anything
nice for NTLMv2 at all.  Don't ask me to explain why this change fixes
win2k - I don't understand it myself!  (-:


Tim.




More information about the samba-cvs mailing list