CVS update: samba/source

[Andrew Bartlett]

Jeremy Allison wrote:
> 
> On Sun, Oct 14, 2001 at 06:27:39PM +1000, Andrew Bartlett wrote:
> >
> > I have a workaround for the package build (and I'm about to upload the
> > RedHat 6.2 package it generated).  I'll commit that, but I'm not entirly
> > sure exactly what the original commit intended so I'll leave that if you
> > don't mind.
> 
> I'm not sure thats a good idea. If the Makefile.in is incorrect I'd
> rather you fix that than put a hack in the spec file.

Yes, the Makefile needs to be fixed.  That is not in dispute.  If you
look at my patch to the specfile you will see that I'm just defining
SBINDIR so when the broken makefile does its stuff we do it all in the
$RPM_BUILD_ROOT, not in /

I'm just asking that a person who understands the 'parallel make' issue
prompting the change fix the Makefile, becouse I can't see why the
change was made in the first place.

> Also, I always build a binary package from the *released* tarball,
> not out of any CVS tree.

This tarball is exactly that.  One better it is the released tarball not
the retared version we normally do.  (I prefer it that way)
 
> This is to ensure that anyone rebuilding the package on the platform
> gets *exactly* the same as the code we released - that's *REALLY*
> important.

Indeed
 
> Please do this for the RH6.2 binary, not from a CVS tree.
> 
> Thanks,
> 
>         Jeremy.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Samba Team member, Build Farm maintainer        abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net