who is creating TESTDIR.TMP ?

Jeremy Allison jra at samba.org
Fri Nov 23 22:18:09 EST 2001


On Fri, Nov 23, 2001 at 01:40:48AM -0800, Andrew Tridgell wrote:
> 
> Easy to reproduce. Map a drive from W2K to Samba HEAD. Open the drive
> in "My Computer". Rick-click/create/new-folder, choose default folder
> name "New Folder". 
> 
> Then look in the directory. There is a TESTDIR.TMP file
> 
> I strongly suspect broken delete on close in NTcreateX, but haven't
> had time to track it down.

Ok. Fixed it in 2.2 and HEAD and checked it in. It has some weird
semantics btw. We need more tests in smbtorture for this one....

They set the delete on close flag, but don't request delete access
in the open. Also, what would happen if this file were already open
denying delete access by another client..... Inquiring smb clients
need to know :-). I fixed it in a "sensible" way for Samba (ie. setting
the delete on close flag implicitly requests delete access, which will
cause the delete on close flag set to fail if another smbd has it
open without FILE_SHARE_DELETE set).

Also, we weren't getting this (delete on close being set on NTcreateandX)
before setting NTSTATUS codes (which are now set in 2.2). I remember
checking and not seeing this....

I'm going to bed now (it's after 3am here). The cipro antibiotics
are really screwing with my sleeping schedules :-(.

Jeremy.




More information about the samba-cvs mailing list